New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slider re-init and destroy #2428

Closed

devgrok wants to merge 1 commit into Dogfalo:master from devgrok:slider-improvements

devgrok commented Dec 6, 2015

These modifications allow the component to be re initialised with different options.

Use case: Meteor detects changes in options and expects to be able to pass them on to the component without regenerating the html (from it's perspective it hasn't changed).
If you want to change the speed at which the images transition etc

Also added a method to allow the component to be destroyed and for the image src url to revert back to it's state pre component init.

Use case: I used this together with print detection. I used css to layout the slides to fill the space but with the image set as a background image trying to get the content to flow around the images was problematic.


          adding destroy function to revert back to pre-init state

3740e1a

allow re-init of component

tomscholz mentioned this pull request

Destroy methods for major javascript components #4522

Closed

7 tasks

tomscholz mentioned this pull request

Reinitializing the same carousel generates multiple indicators #4834

Closed

Collaborator

acburst commented Oct 25, 2017

In v1, with the class rewrite this has been made much easier to destroy and reinit.

acburst closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment