Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Waves to v0.7.5 #5472

Open
Queatz opened this issue Dec 15, 2017 · 2 comments
Open

Update Waves to v0.7.5 #5472

Queatz opened this issue Dec 15, 2017 · 2 comments

Comments

@Queatz
Copy link

Queatz commented Dec 15, 2017

I was looking for a more performant solution for my Angular project besides calling Waves.displayEffect() each time a new component loads and saw that there is now Waves.init() which seems to be a one-time call.

https://github.com/fians/Waves/blob/master/src/js/waves.js
@DanielRuf
Copy link
Contributor

We are currently using a modified waves.js version but we can probably add the init method and migrate the affected lines in Materialize.

@Dogfalo
Copy link
Owner

Dogfalo commented Feb 28, 2018

Why do you need to call displayEffect() multiple times? As long as the element has waves-effect it should still be able to trigger the waves effect without having to call displayEffect()

Niels-Be added a commit to Niels-Be/materialize that referenced this issue Aug 5, 2018
@Niels-Be
Waves: Update to 0.7.6. See Dogfalo#5779, Dogfalo#5472 and Dogfalo#3153
47af6e3 
This is 99% origignal Waves.js code.
The only thing added was the initialisation on dom load in line 31.
Niels-Be added a commit to Niels-Be/materialize that referenced this issue Aug 5, 2018
@Niels-Be
Waves: Update to 0.7.6. See Dogfalo#5779, Dogfalo#5472 and Dogfalo#3153
2835df9 
This is 99% original Waves.js code.
The only thing added was the initialization on DomLoad in line 31.
@Niels-Be Niels-Be mentioned this issue Aug 5, 2018
Open
Niels-Be added a commit to Niels-Be/materialize that referenced this issue Aug 10, 2020
@Niels-Be
Waves: Update to 0.7.6. See Dogfalo#5779, Dogfalo#5472 and Dogfalo#3153
fce7b8b 
This is 99% original Waves.js code.
The only thing added was the initialization on DomLoad in line 31.
@Niels-Be Niels-Be mentioned this issue Aug 10, 2020
Merged
JayDijkstra pushed a commit to JayDijkstra/materialize that referenced this issue Mar 7, 2021
@Niels-Be
Waves: Update to 0.7.6. See Dogfalo#5779, Dogfalo#5472 and Dogfalo#3153
b5ce248 
This is 99% original Waves.js code.
The only thing added was the initialization on DomLoad in line 31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Queatz @DanielRuf @Dogfalo