Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove an invalid line from card component example #212

Merged
merged 3 commits into from
Dec 10, 2014
Merged

remove an invalid line from card component example #212

merged 3 commits into from
Dec 10, 2014

Conversation

deiwin
Copy link
Contributor

@deiwin deiwin commented Dec 10, 2014

No description provided.

@Dogfalo
Copy link
Owner

Dogfalo commented Dec 10, 2014

Why is it invalid? It refers to the teal card title. If I remove it, it becomes this:

img

@will-hart
Copy link

In the original source code both lines 912 and 915 have <span class="card-title">Card Title</span>. Is the repetition required?

@deiwin
Copy link
Contributor Author

deiwin commented Dec 10, 2014

Right, my bad - I was looking at the wrong card. The span on line 912 seems to be hidden. I guess the entire card-image div could be removed from the first card.

@deiwin
Copy link
Contributor Author

deiwin commented Dec 10, 2014

This change now avoids confusion about the span duplication.

Dogfalo added a commit that referenced this pull request Dec 10, 2014
remove an invalid line from card component example
@Dogfalo Dogfalo merged commit 46deeb2 into Dogfalo:master Dec 10, 2014
@Dogfalo
Copy link
Owner

Dogfalo commented Dec 10, 2014

Ah I see what you're talking about now. I'm gonna break up the code demo so that it is more clear too. Thanks for the fix!

@deiwin deiwin deleted the patch-1 branch December 10, 2014 16:29
Smankusors pushed a commit to Smankusors/materialize that referenced this pull request Jan 10, 2022
Fix Dogfalo#175 : Add a docs section on how to change the font stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants