Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Field Validation #3912

Closed
wants to merge 1 commit into from
Closed

Required Field Validation #3912

wants to merge 1 commit into from

Conversation

acebruin
Copy link

  • Fixed bug to catch required fields validation

- Fixed bug to catch required fields validation
@jtuberville
Copy link

This corrects an issue with the html5 "required" attribute not being recognized by the "validate" class handling logic.

@Dogfalo
Copy link
Owner

Dogfalo commented Dec 23, 2016

I'm not entirely sure whether we should be tying the validation style to the validate attribute. Maybe @acburst can chime in as well on what he thinks.

I think this change might be good although it will definitely require some documentation changes if it goes through.

@scote
Copy link
Contributor

scote commented Feb 27, 2017

@acburst may you check this pull request? It would be nice to have this feature in next version.

@tomscholz
Copy link
Contributor

@acburst @Dogfalo Can you check on this please?

@Dogfalo
Copy link
Owner

Dogfalo commented Jul 19, 2017

Merged similar PR here: #4883

@Dogfalo Dogfalo closed this Jul 19, 2017
@acebruin
Copy link
Author

#4883 doesn't have line 61 fix for the selector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants