Solution For Swipeable Tabs Fixed Height #5064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tabs swipeable option is set to true, height is fixed 200px. To solve this, setting carousel-item height to auto which is inside of tabs-content class can be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When tabs swipeable option is set to true, height is fixed 200px. #4148
Swipeable tabs have
.tabs-contentclass so we can use this to solve the problem without affecting the existing carousel system.I set
.carousel-itemheight toautowhich inside of.tabs-contentclass. This solved the problem.Screenshots (if appropriate) or codepen:
Issue and Solution: https://codepen.io/atemiz/pen/BdLOwq
Types of changes
Checklist: