Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in upgrade guide #6440

Open
wants to merge 1 commit into
base: v1-dev
Choose a base branch
from
Open

Typos in upgrade guide #6440

wants to merge 1 commit into from

Conversation

julienc91
Copy link

Proposed changes

Typos in upgrade guide: the Modal's complete callback was renamed onCloseEnd, not onOpenEnd.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DanielRuf
Copy link
Contributor

Merged at materializecss@d357444 and materializecss@fe51546

@DanielRuf DanielRuf mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julienc91 @DanielRuf @roiLeo