Check for existence of keys in delete
routines
#2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all 👋
When calling
delete_all_events
anddelete_temporary_bitop_keys
with an emptykeys
object the following exception is thrown:TypeError: object of type 'NoneType' has no len()
This was also pointed out in the repo of the previous version here: Doist/bitmapist#31
To prevent the error from being thrown I changed the
if len(keys) > 0
check to justif keys
, as this both checks if it exists and if its length is greater than 0 (an empty list is falsy).What do you think about this as a solution?