Reorder zones list so that city of the naming of the timezone comes last #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luxiyalu
commented
Jan 26, 2021
| ("+0800", "Asia/Taipei", '(GMT+0800) Ulaan Bataar'), | ||
| ("+0800", "Asia/Taipei", '(GMT+0800) Taipei'), |
There was a problem hiding this comment.
According to the comment from L180-184, when there are more than 1 city of the same timezone name, we should put the city representing this city at the last order, so that it shows up in selection.
amleczko
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/Doist/Issues/issues/1732
Discovered through test failing, this PR also has an additional change of Updating
Volgograd's timezone from+4to+3. For refernece, please see: