Skip to content

Commit

Permalink
fix: Adjust modal alignment to middle at breakpoint (#821)
Browse files Browse the repository at this point in the history
  • Loading branch information
rfgamaral committed Apr 23, 2024
1 parent c3ac8d1 commit 3aefefb
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.

# v23.2.1

- [Fix] Adjust modal alignment to the middle of the viewport at `800px` breakpoint for improved UX.

# v23.2.0

- [Feat] Add `medium` as a `weight` option for `Header`.
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"email": "henning@doist.com",
"url": "http://doist.com"
},
"version": "23.2.0",
"version": "23.2.1",
"license": "MIT",
"homepage": "https://github.com/Doist/reactist#readme",
"repository": {
Expand Down
16 changes: 13 additions & 3 deletions src/modal/modal.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@
.overlay.fitContent > [data-focus-lock-disabled] {
padding-top: var(--reactist-modal-padding-top);
}
.overlay.fitContent > [data-focus-lock-disabled] .container {
max-height: calc(100vh - 2 * var(--reactist-modal-padding-top));
}

.container {
box-shadow: 0px 2px 8px 0px rgba(0, 0, 0, 0.16);
Expand Down Expand Up @@ -118,6 +115,19 @@
}
}

@media (min-height: 800px) {
.overlay.fitContent > [data-focus-lock-disabled] .container {
max-height: calc(100vh - 2 * var(--reactist-modal-padding-top));
}
}

@media (max-height: 800px) {
.overlay.fitContent > [data-focus-lock-disabled] {
padding-top: var(--reactist-spacing-xxlarge);
justify-content: center;
}
}

/* header */

.buttonContainer {
Expand Down

0 comments on commit 3aefefb

Please sign in to comment.