ci: Run pre-commit --all-files on ci to lint project #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, @jairhenrique! Running this got quite a bit of errors in the current codebase. Can you please try to run an autofix? It looks like a few of them are autofixable |
|
@fbidu there are several mypy errors, when I manage to resolve them all I will let you know. |
|
@@fbidu can you approve to run workflow? |
|
@fbidu fixed ci errors. |
|
Thanks, @jairhenrique! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-commit locally can be ignored with the
--no-verifyparameter. This workflow reinforces code quality.