fix: Check code mark presence instead of any mark in `canInsertSugg…

…estion` (#791)
Doist · May 13, 2024 · 2f70959 · 2f70959
1 parent cf7451f
commit 2f70959
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/utilities/can-insert-suggestion.ts b/src/utilities/can-insert-suggestion.ts
@@ -14,12 +14,14 @@ function canInsertSuggestion({ editor, state }: { editor: Editor; state: EditorS
     const isInsideCodeBlockNode = selection.$from.parent.type.name === 'codeBlock'
 
     const wordsBeforeSelection = (selection.$from.nodeBefore?.text ?? '').split(' ')
+    const nodeBeforeSelection = selection.$from.parent.cut(
+        selection.$from.parentOffset - wordsBeforeSelection.slice(-1)[0].length - 1,
+        selection.$from.parentOffset - 1,
+    ).content.firstChild
 
-    const hasCodeMarkBefore =
-        (selection.$from.parent.cut(
-            selection.$from.parentOffset - wordsBeforeSelection.slice(-1)[0].length - 1,
-            selection.$from.parentOffset - 1,
-        ).content.firstChild?.marks.length ?? 0) > 0
+    const hasCodeMarkBefore = (nodeBeforeSelection?.marks ?? []).some(
+        (mark) => mark.type.name === 'code',
+    )
 
     const isComposingInlineCode = wordsBeforeSelection.some((word) => word.startsWith('`'))