fix(deps): update tiptap packages to v2.1.6 #398
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
![renovate-approve[bot]](https://avatars.githubusercontent.com/in/7394?s=60&v=4){kind=small}
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rfgamaral
force-pushed
the
renovate/tiptap-packages
branch
from
b2a384c
to
27cb57d
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
PR Observations
|
rfgamaral
requested review from
a team,
rfgamaral and
nats12
and removed request for
a team and
rfgamaral
|
@nats12 This PR was created by Renovate and that's why it doesn't have the normal PR structure and no test plan. However, for a test plan, just play with the rich-text editor stories, see if you can find anything unexpected or not working, and double-check the issues that I mentioned in the comment above. @Doist/frontend-product It would be nice if at least someone else besides me and Natalie (assigned reviwer) could also take this for a spin. We all use the editor/composer in different ways, and the more people that test these changes, the merrier. @domjost The long standing bullet list issues have been fixed here (there might be some quirks here and there, but it's much better now). Just letting you know in case you want to take a look before we push this to our products. Everyone, use the Netlify deploy preview for testing: |
@rfgamaral is there a particular use case or test plan that you'd like us to follow? |
|
@jvalente Besides the issues mentioned here, nothing in particular. Those are the issues that we have logged on our side, and have been fixed with this new tiptap version. But it also brought many other bug fixes and improvements, and I just wanted to double-check that we are not introducing any annoying bug with this new version. So, take the editor for a quick spin, try to use it as you normally would in Todoist/Twist, and see if you can break it somehow 😅 |
|
Can confirm that the update addresses the mentioned issues. 👍 |
There was a problem hiding this comment.
@rfgamaral I've tested the above mentioned issues and all seem to be addressed except for the inline code URL one. The below is not what we expect, right?
Steps to reproduce:
- Open ` mark and enter some text plus a url
- Close ` mark
The closing of the code mark after the url seems to place it after the text, and adds the url in its own inline code block.
Yes, I believe that should've been fixed. I couldn't reproduce it myself following your test steps. I could, however, reproduce it by pasting a URL (instead of typing), but that's a completyly different issue. Typing: firefox_REjjM6jVtW.mp4Pasting: firefox_Dzqpk6N97X.mp4So, in a nutshell, typing should be fixed, pasting is a different (non-logged) issue. Can you please confirm if you typed or pasted? If you typed, can you reproduce the issue consistently? Can you post a demo? |
rfgamaral
force-pushed
the
renovate/tiptap-packages
branch
from
27cb57d
to
9fd1b15
Compare
|
@jvalente @nats12 A decision came through and we are keeping the default |
|
|
My apologies, I did indeed paste! I can confirm the issue is fixed when typing 👍🏼 I also re-tested the strikethrough, it works again with the default. |
rfgamaral
changed the title
rfgamaral
force-pushed
the
renovate/tiptap-packages
branch
from
ccee5e7
to
803c666
Compare
rfgamaral
changed the title
rfgamaral
force-pushed
the
renovate/tiptap-packages
branch
from
803c666
to
48c50f8
Compare
rfgamaral
force-pushed
the
renovate/tiptap-packages
branch
from
48c50f8
to
7662169
Compare
## [1.4.5](v1.4.4...v1.4.5) (2023-08-23) ### Bug Fixes * **deps:** update tiptap packages to v2.1.6 ([#398](#398)) ([08d1f6a](08d1f6a))
|
🎉 This PR is included in version 1.4.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR contains the following updates:
2.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.12.0.4->2.1.1This PR also:
Release Notes
ueberdosis/tiptap (@tiptap/core)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/core
v2.1.0Compare Source
Note: Version bump only for package @tiptap/core
ueberdosis/tiptap (@tiptap/extension-blockquote)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-blockquote
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-blockquote
ueberdosis/tiptap (@tiptap/extension-bold)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-bold
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-bold
ueberdosis/tiptap (@tiptap/extension-bullet-list)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-bullet-list
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-bullet-list
ueberdosis/tiptap (@tiptap/extension-character-count)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-character-count
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-character-count
ueberdosis/tiptap (@tiptap/extension-code)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-code
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-code
ueberdosis/tiptap (@tiptap/extension-code-block)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-code-block
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-code-block
ueberdosis/tiptap (@tiptap/extension-document)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-document
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-document
ueberdosis/tiptap (@tiptap/extension-dropcursor)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-dropcursor
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-dropcursor
ueberdosis/tiptap (@tiptap/extension-gapcursor)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-gapcursor
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-gapcursor
ueberdosis/tiptap (@tiptap/extension-hard-break)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-hard-break
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-hard-break
ueberdosis/tiptap (@tiptap/extension-heading)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-heading
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-heading
ueberdosis/tiptap (@tiptap/extension-history)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-history
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-history
ueberdosis/tiptap (@tiptap/extension-horizontal-rule)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-horizontal-rule
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-horizontal-rule
ueberdosis/tiptap (@tiptap/extension-image)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-image
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-image
ueberdosis/tiptap (@tiptap/extension-italic)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-italic
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-italic
ueberdosis/tiptap (@tiptap/extension-link)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-link
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-link
ueberdosis/tiptap (@tiptap/extension-list-item)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-list-item
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-list-item
ueberdosis/tiptap (@tiptap/extension-ordered-list)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-ordered-list
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-ordered-list
ueberdosis/tiptap (@tiptap/extension-paragraph)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-paragraph
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-paragraph
ueberdosis/tiptap (@tiptap/extension-placeholder)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-placeholder
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-placeholder
ueberdosis/tiptap (@tiptap/extension-strike)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-strike
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-strike
ueberdosis/tiptap (@tiptap/extension-task-item)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-task-item
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-task-item
ueberdosis/tiptap (@tiptap/extension-task-list)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-task-list
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-task-list
ueberdosis/tiptap (@tiptap/extension-text)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-text
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-text
ueberdosis/tiptap (@tiptap/extension-typography)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/extension-typography
v2.1.0Compare Source
Note: Version bump only for package @tiptap/extension-typography
ueberdosis/tiptap (@tiptap/pm)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/pm
v2.1.0Compare Source
Note: Version bump only for package @tiptap/pm
ueberdosis/tiptap (@tiptap/react)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/react
v2.1.0Compare Source
Note: Version bump only for package @tiptap/react
ueberdosis/tiptap (@tiptap/suggestion)
v2.1.1Compare Source
Note: Version bump only for package @tiptap/suggestion
v2.1.0Compare Source
Note: Version bump only for package @tiptap/suggestion
Configuration
📅 Schedule: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.