fix: Expose registerMarkdownParser function instead of registering during the component lifecycle #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In this PR, we are changing how we are setting up the
AdaptiveCardRenderer
. In the past, we would register the custom markdown parser in auseEffect
. However, since the AdaptiveCards library only allows you to register a single markdown parser globally, it makes more sense to do so in the global scope instead of in auseEffect
.The main reason for this change is that in the initial render of
AdaptiveCardRenderer
, the markdown parser wasn't registered (becauseuseEffect
runs after the first render) and so markdown was not parsed and was rendered as plain text. This lead to a poor UX with UI Extensions in the first time a markdown-containing Adaptive Card response was rendered.Test plan