Add webhooks support (#23) and improve errors handling (#26) #29
Conversation
Dolfik1
changed the title
|
I should note that combining business logic changes and formatting changes into one commit is not the best idea. This PR is hard to read. |
| @@ -42,6 +42,37 @@ Use Funogram.Api module to communicate with Telegram API with the help of reques | |||
| ``` | |||
| So, that is it! Use Intellisence-driven development approach to explore all Funogram features! For further learning you may take a look at sample Telegram bots built using this library: <a href="https://github.com/Dolfik1/Funogram/tree/master/Funogram.TestBot">Test Bot</a>, <a href="https://github.com/worldbeater/Memes.Bot/tree/master/Memes">Memes Bot</a> | |||
|
|
|||
| # Getting updates via webhooks | |||
| If you want to use webhooks, you should start application with admin privileges. | |||
There was a problem hiding this comment.
It is unclear why you need some "admin privileges". It could be a port requirement from lower 1024 (*nix only, then?) or some silly HTTPS.sys idiosyncrasy (Windows-only, then?); not every OS/environment even has a concept of an "administrator".
Could you please clarify?
There was a problem hiding this comment.
It seems that admin privileges required only for windows system for HttpListener. I cannot claim this since I have not tested it on other systems.
| Error { Description = e.Message; ErrorCode = -1 } | ||
|
|
||
| | _ -> | ||
| Error { Description = "Unknown error"; ErrorCode = -1 } |
There was a problem hiding this comment.
Would it be a good idea to at least try to stringify this unknown response here? As I understand, this case could match if there's Ok x, but neither x.Result nor x.Description is set. Which would be odd, yes, but still possible according to the types, and probably even having somewhat useful string representation.
E.g. | other -> Error { Description = sprintf "Unknown error: %s" other; ErrorCode = -1 }
Ofcourse this is a bad practice. I am sometimes a little lazy to make separate PR's :) |
|
I was making this comment not to mock you, but to maybe a bit encourage to be less lazy. Other people're looking at your project, too. We're honestly interested in it, and we're watching. Every. Little. Step. |
No description provided.