Fix: uniformize code

Dolibarr · Sep 2, 2012 · 0ad137e · 0ad137e
1 parent 00e0649
commit 0ad137e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/htdocs/core/lib/files.lib.php b/htdocs/core/lib/files.lib.php
@@ -139,12 +139,12 @@ function dol_dir_list($path, $types="all", $recursive=0, $filter="", $excludefil
 		closedir($dir);
 
 		// Obtain a list of columns
-		if ($sortcriteria)
+		if (! empty($sortcriteria))
 		{
     		$myarray=array();
     		foreach ($file_list as $key => $row)
     		{
-    			$myarray[$key]  = $row[$sortcriteria];
+    			$myarray[$key] = (isset($row[$sortcriteria])?$row[$sortcriteria]:'');
     		}
     		// Sort the data
     		if ($sortorder) array_multisort($myarray, $sortorder, $file_list);

diff --git a/htdocs/ecm/search.php b/htdocs/ecm/search.php
@@ -48,9 +48,9 @@
 $user->getrights('ecm');
 
 // Get parameters
-$socid = isset($_GET["socid"])?$_GET["socid"]:'';
-$action = isset($_GET["action"])?$_GET["action"]:$_POST['action'];
-$section=isset($_GET["section"])?$_GET["section"]:$_POST['section'];
+$socid = GETPOST('socid','int');
+$action = GETPOST('action','alpha');
+$section=GETPOST('section');
 if (! $section) $section=0;
 
 $upload_dir = $conf->ecm->dir_output.'/'.$section;
@@ -66,9 +66,9 @@
 if (! $sortfield) $sortfield="label";
 
 $ecmdir = new EcmDirectory($db);
-if (! empty($_REQUEST["section"]))
+if (! empty($section))
 {
-	$result=$ecmdir->fetch($_REQUEST["section"]);
+	$result=$ecmdir->fetch($section);
 	if (! $result > 0)
 	{
 		dol_print_error($db,$ecmdir->error);
@@ -123,10 +123,8 @@
 //print "<br>\n";
 print $langs->trans("FeatureNotYetAvailable").'.<br><br>';
 
-if ($mesg) { print $mesg."<br>"; }
-
 // Tool bar
-$head = ecm_prepare_head_fm($fac);
+$head = ecm_prepare_head_fm($ecmdir);
 //dol_fiche_head($head, 'search_form', '', 1);
 
 
@@ -210,7 +208,6 @@
 print '<br>';
 
 // End of page
-$db->close();
-
 llxFooter();
+$db->close();
 ?>