FIX Selection of addmaindocfile is lost on error

Dolibarr · Oct 29, 2018 · 770f8c3 · 770f8c3
1 parent dbb2168
commit 770f8c3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/htdocs/core/class/html.formmail.class.php b/htdocs/core/class/html.formmail.class.php
@@ -881,8 +881,12 @@ function get_form($addfileaction='addfile', $removefileaction='removefile')
 
 				$out.= '<td>';
 
+				if (GETPOSTISSET('sendmail'))
+				{
+					$this->withmaindocfile = (GETPOST('addmaindocfile', 'alpha') ? -1 : 1);
+				}
 				// If a template was selected, we use setup of template to define if join file checkbox is selected or not.
-				if (is_object($arraydefaultmessage) && $arraydefaultmessage->id > 0)
+				elseif (is_object($arraydefaultmessage) && $arraydefaultmessage->id > 0)
 				{
 					$this->withmaindocfile = ($arraydefaultmessage->joinfiles ? -1 : 1);
 				}
@@ -895,7 +899,7 @@ function get_form($addfileaction='addfile', $removefileaction='removefile')
 					}
 					if ($this->withmaindocfile == -1)
 					{
-						$out.='<input type="checkbox" name="addmaindocfile" checked="checked" />';
+						$out.='<input type="checkbox" name="addmaindocfile" value="1" checked="checked" />';
 					}
 					$out.=' '.$langs->trans("JoinMainDoc").'.<br>';
 				}

diff --git a/htdocs/core/tpl/massactions_pre.tpl.php b/htdocs/core/tpl/massactions_pre.tpl.php
@@ -41,11 +41,12 @@
 {
 	$langs->load("mails");
 
+	$listofselectedid = array();
+	$listofselectedthirdparties = array();
+	$listofselectedref = array();
+
 	if (! GETPOST('cancel', 'alpha'))
 	{
-		$listofselectedid = array();
-		$listofselectedthirdparties = array();
-		$listofselectedref = array();
 		foreach ($arrayofselected as $toselectid)
 		{
 			$result = $objecttmp->fetch($toselectid);
@@ -110,8 +111,8 @@
 	} else {
 		$formmail->withtoreadonly = 1;
 	}
-
-	$formmail->withoptiononeemailperrecipient = empty($liste)?0:((GETPOST('oneemailperrecipient')=='on')?1:-1);
+	
+	$formmail->withoptiononeemailperrecipient = (count($listofselectedref) == 1 || empty($liste))? 0 : ((GETPOST('oneemailperrecipient')=='on')?1:-1);
 	$formmail->withto = empty($liste)?(GETPOST('sendto','alpha')?GETPOST('sendto','alpha'):array()):$liste;
 	$formmail->withtofree = empty($liste)?1:0;
 	$formmail->withtocc = 1;