Skip to content

Commit

Permalink
Fix missing php-intl is not blocking (not working on windows)
Browse files Browse the repository at this point in the history
  • Loading branch information
eldy committed Jun 30, 2019
1 parent a992690 commit 8f5b575
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
2 changes: 2 additions & 0 deletions build/exe/doliwamp/php.ini.install
Expand Up @@ -653,6 +653,8 @@ default_socket_timeout = 60
; extension folders as well as the separate PECL DLL download (PHP 5).
; Be sure to appropriately set the extension_dir directive.

; If an extension does not load, run "deplister.exe php_xxx.dll" to get list of dependency dll missing.

extension=php_bz2.dll
extension=php_curl.dll
;extension=php_dba.dll
Expand Down
2 changes: 1 addition & 1 deletion htdocs/core/lib/functions.lib.php
Expand Up @@ -7037,7 +7037,7 @@ function getLanguageCodeFromCountryCode($countrycode)
$buildprimarykeytotest = strtolower($countrycode).'-'.strtoupper($countrycode);
if (in_array($buildprimarykeytotest, $locales)) return strtolower($countrycode).'_'.strtoupper($countrycode);

if (function_exists('locale_get_primary_language')) // Need extension php-intl
if (function_exists('locale_get_primary_language') && function_exists('locale_get_region')) // Need extension php-intl
{
foreach ($locales as $locale)
{
Expand Down
10 changes: 5 additions & 5 deletions htdocs/install/check.php
Expand Up @@ -127,7 +127,7 @@
{
$langs->load("errors");
print '<img src="../theme/eldy/img/warning.png" alt="Error"> '.$langs->trans("ErrorPHPDoesNotSupportGD")."<br>\n";
// $checksok=0; // If image ko, just warning. So check must still be 1 (otherwise no way to install)
// $checksok=0; // If ko, just warning. So check must still be 1 (otherwise no way to install)
}
else
{
Expand All @@ -140,7 +140,7 @@
{
$langs->load("errors");
print '<img src="../theme/eldy/img/warning.png" alt="Error"> '.$langs->trans("ErrorPHPDoesNotSupportCurl")."<br>\n";
// $checksok=0; // If image ko, just warning. So check must still be 1 (otherwise no way to install)
// $checksok=0; // If ko, just warning. So check must still be 1 (otherwise no way to install)
}
else
{
Expand All @@ -153,7 +153,7 @@
{
$langs->load("errors");
print '<img src="../theme/eldy/img/warning.png" alt="Error"> '.$langs->trans("ErrorPHPDoesNotSupportUTF8")."<br>\n";
// $checksok=0; // If image ko, just warning. So check must still be 1 (otherwise no way to install)
// $checksok=0; // If ko, just warning. So check must still be 1 (otherwise no way to install)
}
else
{
Expand All @@ -162,11 +162,11 @@


// Check if UTF8 supported
if (! function_exists("locale_get_primary_language"))
if (! function_exists("locale_get_primary_language") || ! function_exists("locale_get_region"))
{
$langs->load("errors");
print '<img src="../theme/eldy/img/warning.png" alt="Error"> '.$langs->trans("ErrorPHPDoesNotSupportIntl")."<br>\n";
// $checksok=0; // If image ko, just warning. So check must still be 1 (otherwise no way to install)
// $checksok=0; // If ko, just warning. So check must still be 1 (otherwise no way to install)
}
else
{
Expand Down

0 comments on commit 8f5b575

Please sign in to comment.