Add option MAIL_SMTP_USE_FROM_FOR_HELO to fix smtps best practice

Dolibarr · Dec 3, 2017 · b41213f · b41213f
1 parent 9b5f709
commit b41213f
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/htdocs/core/class/smtps.class.php b/htdocs/core/class/smtps.class.php
@@ -512,6 +512,8 @@ function _server_authenticate()
 	 */
 	function sendMsg($_bolTestMsg = false, $_bolDebug = false)
 	{
+		global $conf;
+
 		/**
 		 * Default return value
 		 */
@@ -538,6 +540,15 @@ function sendMsg($_bolTestMsg = false, $_bolDebug = false)
 				$host=preg_replace('@ssl://@i','',$host);	// Remove prefix
 				$host=preg_replace('@tls://@i','',$host);	// Remove prefix
 
+				if (! empty($conf->global->MAIL_SMTP_USE_FROM_FOR_HELO))
+				{
+					// If the from to is 'aaa <bbb@ccc.com>', we will keep 'ccc.com'
+					$host = $this->getFrom('addr');
+					$host = preg_replace('/^.*</', '', $host);
+					$host = preg_replace('/>.*$/', '', $host);
+					$host = preg_replace('/.*@/', '', $host);
+				}
+
 				$_retVal = $this->socket_send_str('HELO ' . $host, '250');
 			}