Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop Conflicts: ChangeLog htdocs/install/mysql/migration/3.6.0-3.7.0.sql
- Loading branch information
Showing
599 changed files
with
10,858 additions
and
3,952 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
eca9408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FHenry You completely f*cked up your cf63f1a commit with this merge.
ref_supplier has gone back to ref_customer/ref_ext breaking the contract module.
@eldy @simnandez We'd better refuse PR that contains merges to avoid such big regressions. My advice would be to use topic branches and rebase them on upstream/develop just before pull requesting.
eca9408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rdoursenaud I don't understand the link between cf63f1a and this big commit. When I check ca9408c91f9f813ee3cdfb4e4f376f720b16bfe locally I have only 4 files changes and not all this mess. I see my name on the top of this commit, but what I've got locally don't look like that. However, I avoid to push PR with so many modifications. The request cocern is here #1760, I have to change this field name after develop PR accepted. As you said now it's revert back to ref_customer..., so new PR to set it as ref_supplier is on the road
eca9408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't precisely know what happened but it sure is a bad merge that introduced regressions.
gives the same result as here on my machine.
Thanks for taking the time to cook a fix 👍
eca9408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your right about branch creation, git-flow. I will force myself to do change on new branch, and not on main ones... The on going PR is the last one like that.