Skip to content

Commit

Permalink
Fix: try another method
Browse files Browse the repository at this point in the history
  • Loading branch information
@hregis
hregis committed Jan 3, 2012
1 parent 6f83a55 commit fea2cdb
Show file tree
Hide file tree
Showing 2 changed files with 220 additions and 1 deletion.
2 changes: 1 addition & 1 deletion build.xml
View file
Expand Up @@ -66,7 +66,7 @@
<!-- Generate checkstyle.xml -->
<target name="phpcs">
<exec executable="phpcs" dir="${basedir}" output="${basedir}/hudson/logs/checkstyle.xml">
<arg line=" --standard=${basedir}/dev/codesniffer/ruleset.xml
<arg line=" --standard=${basedir}/dev/codesniffer/jenkins_ruleset.xml
--report=checkstyle
--ignore=${ignorepaths},${ignoreregexp}
htdocs
Expand Down
219 changes: 219 additions & 0 deletions dev/codesniffer/jenkins_ruleset.xml
View file
@@ -0,0 +1,219 @@
<?xml version="1.0"?>
<!DOCTYPE ruleset SYSTEM "ruleset.dtd">
<ruleset name="Dolibarr">
<description>Dolibarr coding standard.</description>

<!-- List of all tests -->

<rule ref="Generic.CodeAnalysis.EmptyStatement" />

<rule ref="Generic.CodeAnalysis.EmptyStatement.NotAllowedWarning">
<severity>0</severity>
</rule>

<!-- <rule ref="Generic.CodeAnalysis.ForLoopShouldBeWhileLoop" /> -->

<rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall" />

<rule ref="Generic.CodeAnalysis.JumbledIncrementer" />

<rule ref="Generic.CodeAnalysis.UnconditionalIfStatement" />

<rule ref="Generic.CodeAnalysis.UnnecessaryFinalModifier" />

<rule ref="Generic.CodeAnalysis.UnusedFunctionParameter" />
<rule ref="Generic.CodeAnalysis.UnusedFunctionParameter.Found">
<severity>0</severity>
</rule>

<rule ref="Generic.CodeAnalysis.UselessOverridingMethod" />

<rule ref="Generic.Commenting.Todo" />

<!-- Warning if action on same line than if -->
<!--
<rule ref="Generic.ControlStructures.InlineControlStructure">
<properties> <property name="error" value="false"/> </properties>
</rule>
-->

<!-- Lines can be 85 chars long, but never show errors -->
<rule ref="Generic.Files.LineLength">
<properties>
<property name="lineLimit" value="1000" />
<property name="absoluteLineLimit" value="0" />
</properties>
</rule>

<!-- Use Unix newlines -->
<rule ref="Generic.Files.LineEndings">
<properties>
<property name="eolChar" value="\n" />
</properties>
</rule>

<!-- To disallow several statements on same line -->
<!-- <rule ref="Generic.Formatting.DisallowMultipleStatements" /> -->

<!-- Have 2 chars padding maximum and always show as errors -->
<!--
<rule ref="Generic.Formatting.MultipleStatementAlignment">
<properties> <property name="maxPadding" value="2"/> <property
name="ignoreMultiLine" value="true"/> </properties> </rule>
-->

<rule ref="Generic.Formatting.SpaceAfterCast" />

<rule ref="Generic.Functions.CallTimePassByReference" />

<rule ref="Generic.Functions.FunctionCallArgumentSpacing" />
<rule ref="Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma">
<severity>0</severity>
</rule>
<rule
ref="Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma">
<severity>0</severity>
</rule>

<!-- Tweaks to metrics -->
<rule ref="Generic.Metrics.CyclomaticComplexity">
<properties>
<property name="complexity" value="25" />
<property name="absoluteComplexity" value="100" />
</properties>
</rule>
<rule ref="Generic.Metrics.NestingLevel">
<properties>
<property name="nestingLevel" value="6" />
<property name="absoluteNestingLevel" value="50" />
</properties>
</rule>

<rule ref="Generic.NamingConventions.ConstructorName" />
<!-- Check if we use PHP4 constructor instead of __construct() -->
<rule ref="Generic.NamingConventions.ConstructorName.OldStyle">
<severity>0</severity>
</rule>

<rule ref="Generic.NamingConventions.UpperCaseConstantName" />

<rule ref="Generic.PHP.DeprecatedFunctions" />

<rule ref="Generic.PHP.DisallowShortOpenTag" />

<rule ref="Generic.PHP.ForbiddenFunctions" />

<!-- Warning when using @ before functions -->
<!-- <rule ref="Generic.PHP.NoSilencedErrors" /> -->

<!-- Say if null, true, false must be uppercase -->
<!-- <rule ref="Generic.PHP.UpperCaseConstant" /> -->

<rule ref="Generic.Strings.UnnecessaryStringConcat" />

<rule ref="Generic.VersionControl.SubversionProperties" />

<!-- Disallow usage of tab -->
<!-- <rule ref="Generic.WhiteSpace.DisallowTabIndent" /> -->

<!-- Check indent are done with spaces and wiht correct number -->
<!-- Disabled as this does not support tab -->
<!-- <rule ref="Generic.WhiteSpace.ScopeIndent" /> -->

<rule ref="PEAR.Classes.ClassDeclaration" />

<!-- Check for duplicate class names -->
<!-- <rule ref="Generic.Classes.DuplicateClassName" /> -->

<rule ref="PEAR.Commenting.ClassComment" />
<rule ref="PEAR.Commenting.ClassComment.MissingTag">
<severity>0</severity>
</rule>

<!--
<rule ref="PEAR.Commenting.FileComment" />
<rule ref="PEAR.Commenting.FileComment.WrongStyle">
<severity>0</severity>
</rule>
<rule ref="PEAR.Commenting.FileComment.MissingVersion">
<severity>0</severity>
</rule>
<rule ref="PEAR.Commenting.FileComment.MissingTag">
<severity>0</severity>
</rule>
-->
<rule ref="PEAR.Commenting.FunctionComment.WrongStyle">
<severity>0</severity>
</rule>

<rule ref="PEAR.Commenting.FunctionComment.Empty">
<severity>5</severity>
</rule>

<rule ref="PEAR.Commenting.FunctionComment" />
<rule ref="PEAR.Commenting.FunctionComment.SpacingBeforeParamType">
<severity>0</severity>
</rule>
<rule ref="PEAR.Commenting.FunctionComment.SpacingAfterLongType">
<severity>0</severity>
</rule>
<rule ref="PEAR.Commenting.FunctionComment.SpacingAfterLongName">
<severity>0</severity>
</rule>
<rule ref="PEAR.Commenting.FunctionComment.SpacingAfterParams">
<severity>0</severity>
</rule>
<rule ref="PEAR.Commenting.FunctionComment.ParameterCommentsNotAligned">
<severity>0</severity>
</rule>
<rule ref="PEAR.Commenting.FunctionComment.ParameterNamesNotAligned">
<severity>0</severity>
</rule>

<rule ref="PEAR.Commenting.InlineComment" />

<!-- <rule ref="PEAR.ControlStructures.ControlSignature" /> -->

<!-- <rule ref="PEAR.ControlStructures.MultiLineCondition" /> -->

<!-- Test if () are removed for includes -->
<!-- <rule ref="PEAR.Files.IncludingFile"/> -->

<rule ref="PEAR.Formatting.MultiLineAssignment" />

<rule ref="PEAR.Functions.FunctionCallSignature" />

<rule ref="PEAR.Functions.ValidDefaultValue" />

<rule ref="PEAR.NamingConventions.ValidClassName" />
<rule ref="PEAR.NamingConventions.ValidClassName.StartWithCaptial">
<severity>0</severity>
</rule>

<rule ref="PEAR.NamingConventions.ValidFunctionName" />
<rule ref="PEAR.NamingConventions.ValidFunctionName.FunctionNoCaptial">
<severity>0</severity>
</rule>
<rule ref="PEAR.NamingConventions.ValidFunctionName.NotCamelCaps">
<severity>0</severity>
</rule>
<rule ref="PEAR.NamingConventions.ValidFunctionName.PrivateNoUnderscore">
<severity>0</severity>
</rule>

<rule ref="PEAR.NamingConventions.ValidVariableName" />

<rule ref="PEAR.WhiteSpace.ObjectOperatorIndent" />

<rule ref="Squiz.WhiteSpace.ScopeClosingBrace">
<severity>0</severity>
</rule>

<rule ref="Squiz.WhiteSpace.ScopeClosingBrace.Line">
<severity>0</severity>
</rule>

<!-- Already found as a Generic rule -->
<!-- <rule ref="PEAR.WhiteSpace.ScopeIndent" /> -->

</ruleset>

0 comments on commit fea2cdb

Please sign in to comment.