Bug: Openldap password not correctly set

[gali0]

Bug

New created member can't authenticate from LDAP

Environment

• Version: Dolibarr 8.0.4
• OS: Debian 9
• Web server: Apache2
• PHP: PHP7
• Database: Mysql

Use case

I have an OpenLDAP for authenticate members with other apps.
After created a new user and test to bind to LDAP I get "invalid credential"
I've test directly LDAP bind, with "Apache directory studio" and test password function, the password is definively not set correctly by dolibarr.

[gali0]

Ok after research it appears that if I attach the salt found in the database to the password it works. So problem seen to be there.
After searching in the source code I suggest this modification:

replace:

dolibarr/htdocs/core/lib/security.lib.php

Line 125 in 3d4879c

if (! empty($conf->global->MAIN_SECURITY_SALT)) $chain=$conf->global->MAIN_SECURITY_SALT.$chain;

with:
if (! empty($conf->global->MAIN_SECURITY_SALT) && ( ! $type == '4' || ! $type == 'md5openldap')) $chain=$conf->global->MAIN_SECURITY_SALT.$chain;

[github-actions]

This issue is stale because it has been open 1 year with no activity. If this is a bug, please comment to confirm it is still present on latest stable version. if this is a feature request, please comment to notify the request is still relevant and not yet covered by latest stable version. Without comment, this issue will be closed automatically by stale bot in 15 days.