Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] Migration 12.x -> 13.x breaks mailing list titles #16080

Closed
Valcoop opened this issue Jan 27, 2021 · 0 comments
Closed

[Breaking change] Migration 12.x -> 13.x breaks mailing list titles #16080

Valcoop opened this issue Jan 27, 2021 · 0 comments
Labels
Bug This is a bug (something does not work as expected)

Comments

@Valcoop
Copy link
Contributor

Valcoop commented Jan 27, 2021

Bug

Migration 12.x -> 13.x breaks mailing list titles

Environment

  • Version: 13.0
  • OS: Ubuntu 20 LXC
  • Web server: Apache2
  • PHP: PHP 7.4
  • Database: MySQL 8
  • URL(s): /comm/mailing/list.php?leftmenu=mailing

Expected and actual behavior

We should be able to see the titles in the list of mailing lists. After the migration, no titles are shown

Steps to reproduce the behavior

Upgrade from 12.x to 13.x

Possible remediations

Quick fix : In htdocs/comm/mailing/list.php, on line 241, replace $obj->title by $obj->titre (goes against the will of developers to translate variables in english)

Persistent fix : Change all references of m.titre in SQL queries and alter table llx_mailing with title instead of titre

Side note

I wouldn't mind creating a PR for this issue for a persistent fix however I am not sure of how database migrations are handled.
Is it directly in /htdocs/install/mysql/migration/12.0.0-13.0.0.sql ?

@Valcoop Valcoop added the Bug This is a bug (something does not work as expected) label Jan 27, 2021
@eldy eldy closed this as completed in ba3e902 Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected)
Projects
None yet
Development

No branches or pull requests

1 participant