Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paiement.php - BILL_PAYED not working #18181

Closed
TS-NP24 opened this issue Jul 20, 2021 · 7 comments
Closed

paiement.php - BILL_PAYED not working #18181

TS-NP24 opened this issue Jul 20, 2021 · 7 comments
Labels
Bug This is a bug (something does not work as expected)

Comments

@TS-NP24
Copy link

TS-NP24 commented Jul 20, 2021

At the moment it is no longer possible to enter the payment, the process is canceled and a website with an error is displayed.

Input
Input_2
Error


Log:

2021-07-20 12:28:30 DEBUG 192.168.184.199 No notification to thirdparty sent, nothing into notification setup for the thirdparty socid = 42
2021-07-20 12:28:30 DEBUG 192.168.184.199 dol_getIdFromCode (value for field rowid from key BILL_PAYED not found into cache)
2021-07-20 12:28:30 DEBUG 192.168.184.199 sql=SELECT rowid as valuetoget FROM llx_c_action_trigger WHERE code = 'BILL_PAYED'
2021-07-20 12:28:30 ERR 192.168.184.199 DoliDBMysqli::close Closing a connection with an opened transaction depth=3
2021-07-20 12:28:30 WARNING 192.168.184.199 --- End access to /compta/paiement.php (Warn: db disconnection forced, transaction depth was 3)

@TS-NP24
Copy link
Author

TS-NP24 commented Jul 20, 2021

The same problem occurs as soon as you want to mark the invoice as paid.

Error_2
Error_2_2

URL: compta/facture/card.php?facid=219

LOG:
2021-07-20 12:49:47 DEBUG 192.168.184.199 No notification to thirdparty sent, nothing into notification setup for the thirdparty socid = 42
2021-07-20 12:49:47 DEBUG 192.168.184.199 dol_getIdFromCode (value for field rowid from key BILL_PAYED not found into cache)
2021-07-20 12:49:47 DEBUG 192.168.184.199 sql=SELECT rowid as valuetoget FROM llx_c_action_trigger WHERE code = 'BILL_PAYED'
2021-07-20 12:49:47 ERR 192.168.184.199 DoliDBMysqli::close Closing a connection with an opened transaction depth=1
2021-07-20 12:49:47 WARNING 192.168.184.199 --- End access to /compta/facture/card.php (Warn: db disconnection forced, transaction depth was 1)

@TS-NP24
Copy link
Author

TS-NP24 commented Jul 20, 2021

The problem has existed since version 14

@ksar-ksar
Copy link
Contributor

Hello,

Error 500 = PHP error => Have a look on the apache log

@TS-NP24
Copy link
Author

TS-NP24 commented Jul 20, 2021

[20-Jul-2021 15:18:22 Europe/Berlin] PHP Fatal error: Uncaught Error: Object of class Conf could not be converted to string in D:\inetpub\dolibarr_TEST\htdocs\core\class\notify.class.php:690
Stack trace:
#0 D:\inetpub\dolibarr_TEST\htdocs\core\triggers\interface_50_modNotification_Notification.class.php(97): Notify->send('BILL_PAYED', Object(Facture))
#1 D:\inetpub\dolibarr_TEST\htdocs\core\class\interfaces.class.php(183): InterfaceNotification->runTrigger('BILL_PAYED', Object(Facture), Object(User), Object(Translate), Object(Conf))
#2 D:\inetpub\dolibarr_TEST\htdocs\core\class\commonobject.class.php(5440): Interfaces->run_triggers('BILL_PAYED', Object(Facture), Object(User), Object(Translate), Object(Conf))
#3 D:\inetpub\dolibarr_TEST\htdocs\compta\facture\class\facture.class.php(2418): CommonObject->call_trigger('BILL_PAYED', Object(User))
#4 D:\inetpub\dolibarr_TEST\htdocs\compta\paiement\class\paiement.class.php(393): Facture->setPaid(Object(User), '', '')
#5 D:\inetpub\dolibarr_TEST\htdocs\compta\paiement.php(256): Paiemen in D:\inetpub\dolibarr_TEST\htdocs\core\class\notify.class.php on line 690
[20-Jul-2021 15:18:50 Europe/Berlin] PHP Deprecated: Directive 'track_errors' is deprecated in Unknown on line 0

@TS-NP24
Copy link
Author

TS-NP24 commented Jul 20, 2021

PHP Fatal error: Uncaught Error: Object of class Conf could not be converted to string in htdocs\core\class\notify.class.php:690

The error did not occur in version 10, 11, 12 and 13. Only since the update to version 14 does the problem persist.

Dolibarr:
DB Version: 14.0.0

First Setup: 10.0.2

PHP:
Version 7.4.12

OS:
Windows Server 2019

@ksar-ksar
Copy link
Contributor

There is a mistake on Line :

$dir_output = $$conf->facture->dir_output."/".get_exdir(0, 0, 0, 1, $object, 'invoice');

$dir_output = $$conf->facture->dir_output."/".get_exdir(0, 0, 0, 1, $object, 'invoice');

There is a double $$

@ksar-ksar ksar-ksar mentioned this issue Jul 20, 2021
@ksar-ksar ksar-ksar added the Bug This is a bug (something does not work as expected) label Jul 20, 2021
@TS-NP24
Copy link
Author

TS-NP24 commented Jul 20, 2021

Yes, it works perfectly after the change. Thanks!

eldy added a commit that referenced this issue Aug 3, 2021
@eldy eldy closed this as completed in 4d6b63d Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected)
Projects
None yet
Development

No branches or pull requests

2 participants