Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with PaymentBankTransfer Line page management #21472

Closed
josett225 opened this issue Jul 7, 2022 · 3 comments
Closed

Bug with PaymentBankTransfer Line page management #21472

josett225 opened this issue Jul 7, 2022 · 3 comments
Labels
Bug This is a bug (something does not work as expected)

Comments

@josett225
Copy link
Contributor

josett225 commented Jul 7, 2022

Bug

When using PaymentBankTransfer Line list page (/compta/prelevement/list.php?type=bank-transfer&mainmenu=bank), there is an issue when trying to increase number of lines or swaping to another page : next page is jumping to prevelement list page. We are then unable to see next pages
See screenshots :
Before issue Payment BankTransfer Line list page
Pb Dolibarr List Paiement Pat Virement Screenshot at Jul 08 01-19-01
After selecting 30 lines move to another list
Pb Dolibarr List Paiement Par Virement Screenshot at Jul 08 01-19-01

Environment Version

14.x 15.x 16.x

Environment OS

No response

Environment Web server

No response

Environment PHP

No response

Environment Database

No response

Environment URL(s)

No response

Expected and actual behavior

No response

Steps to reproduce the behavior

No response

Attached files

No response

@josett225 josett225 added the Bug This is a bug (something does not work as expected) label Jul 7, 2022
@josett225
Copy link
Contributor Author

Hi There,

The issue when swapping the number of lines per pages (from 25 to 30) is also present in the 2 following menus :

(Payment by credit transfer -[Credit transfer orders])
/compta/prelevement/orders_list.php?type=bank-transfer&mainmenu=bank

is swapping to :
(Payment by direct debit - [New direct debit order])
/compta/prelevement/orders_list.php

AND

(Payment by credit transfer - [Credit transfer order lines]
/compta/prelevement/list.php?type=bank-transfer&mainmenu=bank

is swapping to

Payment by direct debit [Direct debit order lines]
/compta/prelevement/list.php

Any suggestion on how to fix this?

Regards

Jose

@josett225
Copy link
Contributor Author

josett225 commented Jul 16, 2022

Hi There
To fix the issue, here is the code added on /compta/prelevement/list.php line 181
if ($type == 'bank-transfer') { print '<form method="POST" id="searchFormList" action="'.$_SERVER["PHP_SELF"].'?type=bank-transfer">'."\n"; } else { print '<form method="POST" id="searchFormList" action="'.$_SERVER["PHP_SELF"].'">'."\n"; }

Here is the code added on /compta/prelevement/orders_list.php line 148
if ($type == 'bank-transfer') { print '<form method="POST" id="searchFormList" action="'.$_SERVER["PHP_SELF"].'?type=bank-transfer">'; } else { print '<form method="POST" id="searchFormList" action="'.$_SERVER["PHP_SELF"].'">'; }

Best Regards

Jose

aspangaro added a commit to aspangaro/dolibarr that referenced this issue Jul 18, 2022
…hes to the lists of the direct debit module
aspangaro added a commit to Easya-Solutions/dolibarr that referenced this issue Jul 18, 2022
…hes to the lists of the direct debit module
@josett225
Copy link
Contributor Author

Hi @aspangaro,

After testing deeper, when using the selectbox of number of items type = bank-transfer.
It seems the JS Code in function print_fleche_navigation in /htdocs/core/lib/functions.lib.php is not taking in consideration the type value.

When selecting we lost the page as before. See video included. This does not work neither in list.php or order_list.php

Let me know if you need more information.

BUG.FONCTIONNEL.ORDRE.DE.VIREMENT.LISTE.1-2.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected)
Projects
None yet
Development

No branches or pull requests

2 participants