Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product - The link in an error message is badly formatted #22952

Closed
thibdrev opened this issue Nov 24, 2022 · 1 comment
Closed

Product - The link in an error message is badly formatted #22952

thibdrev opened this issue Nov 24, 2022 · 1 comment
Assignees
Labels
Bug This is a bug (something does not work as expected) DevCamp 2022 Nantes

Comments

@thibdrev
Copy link
Contributor

Bug

See attached in a French instance of Dolibarr 16.0.2:
Capture

Environment Version

16.0.2

Environment OS

LInux

Environment Web server

Apache

Environment PHP

7.4

Environment Database

MariaDB

Environment URL(s)

htdocs/product/fournisseurs.php

Expected and actual behavior

Expected: error message with URL correctly formatted.
Actual: error message with URL badly formatted.

Steps to reproduce the behavior

  1. Create a 1st product. Give it a price and supplier reference.
  2. Create a 2nd product. Give it a price and the same supplier reference as in 1.
  3. The error shall pop up.

Attached files

I think the key to the translated error message is: ReferenceSupplierIsAlreadyAssociatedWithAProduct.

Located in Transifex here: https://www.transifex.com/dolibarr-association/dolibarr/translate/#fr_FR/suppliers/12458879

And called in the code here:

$texttoshow = $langs->trans("ReferenceSupplierIsAlreadyAssociatedWithAProduct", '{s1}');

@thibdrev thibdrev added the Bug This is a bug (something does not work as expected) label Nov 24, 2022
@bafbes bafbes self-assigned this Nov 25, 2022
eldy added a commit that referenced this issue Nov 25, 2022
@bafbes bafbes added PR to fix - Continuous Integration Test failed The PHP unit tests return something wrong with our code. Check the details to know what to fix. PR OK to merge PR was analyzed by PR merger and seems ok to be validated. Merge may occurs soon... DevCamp 2022 Nantes labels Nov 25, 2022
@eldy eldy removed PR OK to merge PR was analyzed by PR merger and seems ok to be validated. Merge may occurs soon... PR to fix - Continuous Integration Test failed The PHP unit tests return something wrong with our code. Check the details to know what to fix. labels Apr 1, 2023
@eldy
Copy link
Member

eldy commented Apr 1, 2023

Seems fixed with #22987

@eldy eldy closed this as completed Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected) DevCamp 2022 Nantes
Projects
None yet
Development

No branches or pull requests

3 participants