Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date in buy price update doesn't update on changes ! #28710

Closed
le-reparateur opened this issue Mar 8, 2024 · 4 comments
Closed

date in buy price update doesn't update on changes ! #28710

le-reparateur opened this issue Mar 8, 2024 · 4 comments
Labels
Bug This is a bug (something does not work as expected)

Comments

@le-reparateur
Copy link
Contributor

Bug

As you change a purchase price, the new date to apply on this price is not updated in the product card -> buy price

Dolibarr Version

No response

Environment PHP

8.2.7

Environment Database

mariadb 10.11.4

Steps to reproduce the behavior and expected behavior

update a buy price in product card

Attached files

No response
@le-reparateur le-reparateur added the Bug This is a bug (something does not work as expected) label Mar 8, 2024
@le-reparateur le-reparateur changed the title date in purchase update doesn't update on changes ! date in buy price update doesn't update on changes ! Mar 8, 2024
@le-reparateur
Copy link
Contributor Author

solved by :
$sql .= ", datec = '".$this->db->idate($now)."'"; // mise à jour de la date
added line 421 in /fourn/class/fournisseur.product.class.php

@JonBendtsen
Copy link
Contributor

solved by : $sql .= ", datec = '".$this->db->idate($now)."'"; // mise à jour de la date added line 421 in /fourn/class/fournisseur.product.class.php

Good, may I suggest that you edit the file here https://github.com/Dolibarr/dolibarr/blob/develop/htdocs/fourn/class/fournisseur.product.class.php by clicking the little pencil icon. When you do so, please add #28710 in the commit message

Then you submit a Pull Request and add #28710 in the Pull Request message.

@JonBendtsen
Copy link
Contributor

@le-reparateur

le-reparateur added a commit to le-reparateur/dolibarr that referenced this issue Mar 9, 2024
@le-reparateur
Update fournisseur.product.class.php
95e893f 
Dolibarr#28710
@le-reparateur le-reparateur mentioned this issue Mar 9, 2024
Merged
eldy added a commit that referenced this issue Mar 9, 2024
@le-reparateur @eldy
Update fournisseur.product.class.php (#28729)
b601dab 
* Update fournisseur.product.class.php

#28710

* Update fournisseur.product.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
@ksar-ksar
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug This is a bug (something does not work as expected)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JonBendtsen @ksar-ksar @le-reparateur