Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: supplier invoice clone, label field can't be modified after validating #5224

Closed
lucanot opened this issue May 18, 2016 · 4 comments
Closed

Bug: supplier invoice clone, label field can't be modified after validating #5224

lucanot opened this issue May 18, 2016 · 4 comments
Labels
Works for me / Can't reproduce It seems not possible to reproduce the bug.

Comments

@lucanot
Copy link

lucanot commented May 18, 2016

Environment

  • Version: 3.9.0
  • OS: Linux
  • Web server: Apache/2.2.15
  • PHP: apache2handler 5.5.35
  • Database: MySQL or MariaDB 5.5.49
  • URL: /dolibarr/htdocs/fourn/facture/card.php?facid=733

Report

When I use the 'clone' btn , the label field keeps the original value of the source, no matter it's changed. Prior to validation, it seems changes are retained, but after pressing the 'validate' btn they aren't.
I had to manually edit the DB table llx_facture_fourn seeking record(s) by id
@atm-maxime
Copy link
Member

Hi,

I just tested in the latest 3.9 build and I can't reproduce. After cloning a supplier invoice, the "Supplier ref" field is directly in edit mode. After validating this one, I modified the label field. Saving worked fine, even after validating the invoice.

Can you check and provide screen shots ?

@atm-maxime atm-maxime added the Works for me / Can't reproduce It seems not possible to reproduce the bug. label Jun 3, 2016
tiaris added a commit to tiaris/dolibarr that referenced this issue Jun 4, 2016
@tiaris
Dolibarr#5224 Adding "Copyof" before invoice label to remind user to …
1ab2828 
…change it

and avoid label to be the label of cloned invoice
tiaris added a commit to tiaris/dolibarr that referenced this issue Jun 4, 2016
@tiaris
Dolibarr#5224 Adding "Copyof" before invoice label to remind user to …
b350497 
…change it

and avoid label to be the label of cloned invoice
@tiaris tiaris mentioned this issue Jun 4, 2016
Closed
tiaris added a commit to tiaris/dolibarr that referenced this issue Jun 4, 2016
@tiaris
Revert "Dolibarr#5224 Adding "Copyof" before invoice label to remind …
6873e7a 
…user to change it and avoid label to be the label of cloned invoice "

This reverts commit b350497.
@tiaris
Copy link
Contributor

tiaris commented Jun 4, 2016

Seems to work in 4.0 also

@marcosgdf
Copy link
Contributor

Can this issue be closed?

@simnandez
Copy link
Member

I close this issue, because is not reproducible in maintened versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Works for me / Can't reproduce It seems not possible to reproduce the bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@marcosgdf @simnandez @tiaris @atm-maxime @lucanot