Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

country_id of "Don" object is still empty #5474

Closed
rassakali opened this issue Jul 10, 2016 · 0 comments
Closed

country_id of "Don" object is still empty #5474

rassakali opened this issue Jul 10, 2016 · 0 comments

Comments

@rassakali
Copy link
Contributor

Bug

When I use:

$object = new Don($db);
$object->fetch($id);
echo $object->country_id

country_id is still empty

Environment

  • Version: [3.8.3]

problem cause

In the source "dolibarr/don/class/don.class.php" lines 648 there are:
$this->country_id = $obj->country_id;
but country_id not in the $sql query

Suggested implementation

the line 648 must be :
$this->country_id = $obj->fk_country;
OR
add country_id in $sql like that:
$sql.= " d.fk_country as country_id,....

simnandez pushed a commit that referenced this issue Jul 17, 2016
FIX #5474 Country_id of "Don" object is still empty
@eldy eldy closed this as completed in 1232e25 Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant