Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad PDF generation in Expense Report using standard template #7594

Closed
steel67 opened this issue Oct 8, 2017 · 11 comments
Closed

Bad PDF generation in Expense Report using standard template #7594

steel67 opened this issue Oct 8, 2017 · 11 comments

Comments

@steel67
Copy link

steel67 commented Oct 8, 2017

Bug

Using the standard template in French to generate a complex (many lines) Expense report I notices that:

  • the type column is to small and cannot fit a text like Transport, Autre or even Repas without a line break
  • The column Total TTC is too large
  • Some page break appears at the middle of an expense row

Environment

  • Version: 6.01 & 6.02 tested
  • Web server: OVH
  • PHP: 7

[Attached files]

[Files]
Largeur colonne
columnswidth_2017-10-08_110027

Sauts de lignes
pageberak_1_2017-10-08_110704
pageberak_2_2017-10-08_110704
pageberak_3_2017-10-08_110704

@laudeco
Copy link
Member

laudeco commented Oct 9, 2017

I had the same issue, already investigated but not found the exact error ...

@frederic34
Copy link
Contributor

with module project enabled -> good
without module project -> bad

@frederic34
Copy link
Contributor

in /htdocs/core/modules/expensereport/doc/pdf_standard.modules.php
try to replace about lines 115 ... 120
if (empty($conf->projet->enabled)) {
$this->posxtva-=20;
$this->posxup-=20;
$this->posxqty-=20;
$this->postotalttc-=20;
}

with
if (empty($conf->projet->enabled)) {
$this->posxtva-=15;
$this->posxup-=15;
$this->posxqty-=15;
$this->postotalttc-=10;
}

@steel67
Copy link
Author

steel67 commented Oct 23, 2017

Nice catch @frederic34 !

@steel67
Copy link
Author

steel67 commented Nov 3, 2017

Unfortunately it has not been fixed in 6.0.3

@n15c
Copy link
Contributor

n15c commented Dec 5, 2018

Same here

@aljawaid
Copy link
Contributor

aljawaid commented Dec 5, 2018

This has been extremely improved in #10064 which I think will be in v9.0 thanks to @frederic34

@n15c
Copy link
Contributor

n15c commented Dec 6, 2018

This has been extremely improved in #10064 which I think will be in v9.0 thanks to @frederic34

I just tried the fixed file but still have the same problem. Is there something else i have to change?

@aljawaid
Copy link
Contributor

aljawaid commented Dec 6, 2018

@n15c I had a new expense report created to improve the overrall layout after the @frederic34 patch.... will share it to the forum today or tomorrow https://www.dolibarr.org/forum/index but it is tested for v7 and v8

@aljawaid
Copy link
Contributor

aljawaid commented Dec 6, 2018

@reivaxm
Copy link

reivaxm commented May 26, 2019

Same in 9.0.3

simicar29 added a commit to simicar29/dolibarr that referenced this issue Apr 11, 2020
eldy added a commit that referenced this issue Apr 12, 2020
FIX #7594 Expense report multi pagebreak
@eldy eldy closed this as completed in 9573f12 Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants