Bug: The need/required list is wrong in Technical services provided page

[dolibarr95]

Environment

• Version: 6.0.0
• OS: Linux otos.planethoster.net
• Web server: LiteSpeed
• PHP: 5.6.28
• Database: MySQL or MariaDB 10.1.19-MariaDB
• URL(s): admin/modules.php

Bug

I don't know if this is a bug or a misunderstanding on my part. The need/required list is wrong in Technical services provided page.

Actual behavior

In a module descriptor modmymod.class.php:

Case 1.

//$this->depends = array('thirdparty');
//$this->requiredby = array('factory');

will display in Technical services provided page:

This module need the module(s): None
This module is required by module(s): None

Case 2.

//$this->depends = array('thirdparty');
$this->requiredby = array('factory');

This module need the module(s): None
This module is required by module(s): factory

Case 3.

$this->depends = array('thirdparty');
//$this->requiredby = array('factory');

This module need the module(s): None
This module is required by module(s): None

Case 4.

$this->depends = array('thirdparty');
$this->requiredby = array('factory');

This module need the module(s): thirdparty
This module is required by module(s): factory

Expected behavior

Case 3.

$this->depends = array('thirdparty');
//$this->requiredby = array('factory');

This module need the module(s): thirdparty
This module is required by module(s): None

Tks!

[hregis]

@dolibarr95
file /admin/modulehelp.php line 368
wrong test :

if (count($objMod->requiredby)) $text.=join(',', $objMod->depends);

change with :

if (count($objMod->depends)) $text.=join(',', $objMod->depends);

[dolibarr95]

Tks for this quick reply
I will make the PR know

[dolibarr95]

PR done tks.