Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products & Services search only returns products #7714

Closed
hameau opened this issue Oct 26, 2017 · 3 comments
Closed

Products & Services search only returns products #7714

hameau opened this issue Oct 26, 2017 · 3 comments
Labels
Bug This is a bug (something does not work as expected)

Comments

@hameau
Copy link

hameau commented Oct 26, 2017

Bug

Products & Services search only returns products.

Environment

  • Version: 6.0.2
  • OS: - public demo : demo.dolibarr.org -
  • Web server: - public demo -
  • PHP: - public demo -
  • Database: - public demo -
  • URL(s): /product/list.php?sall=test (example result page)

Expected and actual behavior

Expected:
Searching using the global Search box, top of the left column (Eldy theme), should return result from both Products and Services.

Actual:
Search only returns results of type Product, does not include Services, even when there are services that fit the search criteria.

Steps to reproduce the behavior

Example for demo.dolibarr.org.

  • From any page, type the word 'test' in the Search box.
  • From the list of search targets, select 'Products or Services'.
  • The search result page(s) only show search results of type Product, even when there are services that fit the search criteria.

For comparison, starting with a list of services.

  • Select the Products|Services top-level menu option.
  • In the left column, select Services->List.
  • Type the word 'test' in the search box above the Label column; press Enter or click the search icon.

It can be seen that there are services that include 'test' in the label text, but these are not found by the global search feature.

@hameau
Copy link
Author

hameau commented Oct 26, 2017

It seems that the call to /product/list.php should have &type=-1 appended.

For the global search test described above for demo.dolibarr.org, if I manually edit the results list page url to /product/list.php?sall=test&type=-1, I get the search results expected (results show products and services).

@hurricane66750
Copy link

I have the same result, can you take into account this request for correction please.

@atm-maxime
Copy link
Member

Hello,

Thanks for the feedback. It has been fixed in #7758

@atm-maxime atm-maxime added the Bug This is a bug (something does not work as expected) label Nov 15, 2017
atm-john added a commit to atm-john/dolibarr that referenced this issue Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected)
Projects
None yet
Development

No branches or pull requests

3 participants