Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear message proposing a missing component, install fails even after installing it #7751

Closed
MagicFab opened this issue Nov 2, 2017 · 3 comments

Comments

@MagicFab
Copy link
Contributor

MagicFab commented Nov 2, 2017

When installing DoliWAMP an error message indicating there is a missing file provides a link to:
https://www.microsoft.com/en-us/download/details.aspx?id=30679

selection_102

The HTML in the error message is not rendered resulting in a link that can't be clicked. The text can't be selected to cut & paste either making it more difficult to install this required file. The error message is also presented after uncompressing all files, perhaps this requirement check could be done earlier.

After installing the 64 bit version of the "Visual C++ Redistributable for Visual Studio 2012 Update 4", the installer complains about missing MSVCR110.dll. This error also show up several times when trying to remove a failed install:

selection_101

After closely reading the first error message it seems the 32-bit version should be installed instead, I will test this next.

@MagicFab
Copy link
Contributor Author

MagicFab commented Nov 2, 2017

Once the 32-bit version was installed, the installation completed without issues. A message asking to configure the Windows firewall also appeared, I chose LAN access only.
The error message should indicate the 32-bit version is required, the requirements documentation should also be updated.

@MagicFab
Copy link
Contributor Author

MagicFab commented Nov 3, 2017

I would propose using the following text in the error message:
"The Visual C++ Redistributable should be installed, it seems it is not. Please install the 32-bit version from $URL, then restart the DoliWAMP installation/upgrade."

MagicFab added a commit to MagicFab/dolibarr that referenced this issue Nov 5, 2017
@MagicFab MagicFab changed the title Link in message indicating required vcredist_x86.exe can't be clicked, install fails even after installing it Unclear message proposing a missing component, install fails even after installing it Nov 5, 2017
@MagicFab
Copy link
Contributor Author

MagicFab commented Nov 5, 2017

I'll open a separate issue to propose to open the web page proposing the installer, HTML links can't be part of MsgDialog in Inno Setup.

eldy added a commit that referenced this issue Nov 5, 2017
@eldy eldy closed this as completed in #7772 Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant