Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customer code in customer orders documents #11119

Merged
merged 2 commits into from Jun 21, 2019
Merged

Add customer code in customer orders documents #11119

merged 2 commits into from Jun 21, 2019

Conversation

openthink-laurent
Copy link
Contributor

No description provided.

@openthink-laurent
Copy link
Contributor Author

Could anyone review this? Thank you.

@saxa
Copy link

saxa commented Jun 21, 2019

This just add the customer code on one of the documents, probably would be better if you would add it to all standard documents, and you would describe what this PR does next time. Although I do not have
permissions to push it up I am just suggesting you to fix it that way. Maybe I am wrong but where is this setting done ? Is there some configuration needed ?

Rgds
Saxa

Because we have a lot of information and the REF is better to retrieve/search an order and know the customer code, i added a hidden option to show this field.
@eldy eldy merged commit bbbd066 into Dolibarr:develop Jun 21, 2019
@atm-maxime
Copy link
Member

@eldy, now you have to add your option in all other documents models, code_client is already on proposals, invoices, ...

@openthink-laurent
Copy link
Contributor Author

The main documents for customers (invoices, commercial proposals and even interventions...) already mention the customer code, so it makes sense to add it the same way on customer orders. I do not agree with the addition of the option "DOC_SHOW_CUSTOMER_CODE" for customer orders, or at least the same thing should be done for all documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants