FIX: #12908 User login with credentials from self-subscription form fails #12937
Conversation
| @@ -966,30 +966,32 @@ public function delete($rowid, $user, $notrigger = 0) | |||
| * @param int $nosyncuser Do not synchronize linked user | |||
| * @return string If OK return clear password, 0 if no change, < 0 if error | |||
| */ | |||
| public function setPassword($user, $password = '', $isencrypted = 0, $notrigger = 0, $nosyncuser = 0) | |||
| public function setPassword($user, $password = '', $password_indatabase_crypted = '', $isencrypted = 0, $notrigger = 0, $nosyncuser = 0) | |||
There was a problem hiding this comment.
When you add a new parameter, it must always be at end or you break compatibility.
You must add it into the header doc of method or Continuous integration tests will fails.
Also, i don't understand why you need to add a parameter to setPassword. setPassword goal is to change the password from a new value, so only the new value should be required ?
There was a problem hiding this comment.
create_from_member was taking from database an empty password. "member" did have pass_indatabase_crypted but wasnt being used by setPassword so I was trying to add it too and use pass_indatabase_crypted instead of password when possible.
I didn't think in break compatibility, sorry. Now I just add a parameter called "alreadyencrypted" at end of the method setPassword that check is the password added is encrypted or not. I hope this solution is better than the previos one.
I change both setPassword (in user.class and adherent.class) to avoid adherent.class encryp again the password cause was making imposible to login via public formulary.
eldy
added
the
Discussion
…ent, prices/quantity/etc appear on the last relevant page
|
#11975 When a product is split between multiple pages in a document, prices/quantity/etc appear on the last relevant page Added hidden option called MAIN_PDF_DATA_ON_FIRST_PAGE |
|
It seems other changes from other PR were introduced here into this PR. So i close the PR and i pushed a fix manually in commit be2d649 |
No description provided.