-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW add Opening Balance column to balance.php #13067
Conversation
Here we are losing an important feature making the report grouped by account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button "group by" is not yet. My suggestion is to add it so we won't loose the existing feature.
If you may, kindly provide a screenshot of the "existing feature" that would break by adding an Opening Balance column. So far, I tested balance.php by sorting by 'Financial Account', as well as search filter options and those work without issues. Alternatively, if you would rather have this new version of balance.php as a separate page, say openingbalance.php, and have a button from balance.php that links to openingbalance.php (passing over search filter parameters), then that's also fine with me. Thank you. |
Re-implemented this as a separate view that can be toggled, similar to how the Ledger page views (list.php and listbyaccount.php) are implemented. Thanks. |
So, i misunderstood what was the goal of your PR. I though you move the breakdown of accounting account as a simple column, this is why i guide you to this change. I finally revert your PR to take last version - 1. |
The merge didn't take the commit. |
FIX #13067 including opening balance in calculation of displayed balance
Add Opening Balance column to balance.php where colspans and line break widths are adjusted accordingly.