Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX load extra fields langs in list view #14146

Conversation

lvessiller-opendsi
Copy link
Contributor

FIX load extra fields langs in list view
When you add an extra field with lang file (example : "mymodule@mymodule") and set "MyModuleExtrafield1" for translate key, this extra field is not translated in view list.
However, this extra field is translated in create and modify forms.

@eldy
Copy link
Member

eldy commented Jul 29, 2020

Having IO by a disk file read, in a method whose goal is to init an array in memory is a little bit hurting me and seems to introduce overload. Because translation should be requested later when we need to use the translation key and it should be done by the "include" files that manage extra fields. I do not experience this trouble of lang not loaded in list.
Do you have an example of list that is concerned by this bug ?.

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Jul 29, 2020
@lvessiller-opendsi
Copy link
Contributor Author

@eldy
For example : if you create your own module "Alfa3a" and you add an extra field "Alfa3aContactGender" on contact list and set "alfa3a@alfa3a" in lang file. You create the lang file with translate key "Alfa3aContactGender". You see column in contact list but it's not translated.

image

@eldy eldy closed this in 39a5583 Aug 4, 2020
@eldy
Copy link
Member

eldy commented Aug 4, 2020

Thanks. I pushed another way to fix

@lvessiller-opendsi
Copy link
Contributor Author

@eldy
Ok, it fixes in column field of the list. However, you have the same problem in selected fields (multiSelectArrayWithCheckbox in form method).

image

eldy added a commit that referenced this pull request Aug 7, 2020
@lvessiller-opendsi lvessiller-opendsi deleted the v10-fix-extrafield-langs-load branch November 9, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants