Fix: User can see events that are not assigned to it #14355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Aug 4, 2020
htdocs/core/lib/security.lib.php
Outdated
| @@ -247,6 +248,25 @@ function restrictedArea($user, $features, $objectid = 0, $tableandshare = '', $f | |||
| { | |||
| if (! $user->rights->projet->lire && ! $user->rights->projet->all->lire) { $readok=0; $nbko++; } | |||
| } | |||
| elseif ($feature == 'agenda') | |||
There was a problem hiding this comment.
This part of code is dedicated to check on brut permission only, whatever is object analyzed. Few lines later, there is a call to
checkUserAccessToObject()
If we must make a test on a dedicated object id, we must add it in this function checkUserAccessToObject .
Can you try to move this code into this function checkUserAccessToObject()
eldy
added
the
PR to fix or conflict to solve
|
Hi @eldy I have moved it inside the function checkUserAccessToObject |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can see events that are not assigned if he accesses directly through the url. The function only checks that the user has permission to view their events, but not if the user is assigned to that event.