V12 Update html.form.class.php to complete Fix #15565 Enhanced behaviour to select product on customer/supplier order to be able to use barcode reader efficiently #15721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completes Fix Dolibarr#15565 Enhanced behaviour to select product on customer/supplier order to be able to use barcode reader efficiently $conf->global->PRODUIT_USE_SEARCH_TO_SELECT, 0, becomes $conf->global->PRODUIT_USE_SEARCH_TO_SELECT, 1, to speed up customer order filling with product selected by barcode readers.
zuiko
changed the title
|
Because this may have not yet identified side effect, i will not merge this in v12 that is already released ans stable. So i keep only the ticket done into develop / v13 |
|
OK, eldy, I understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PR #15565 on V12 branch
Answer to eldy about its partial commit for fixing PR #15565
In fact change in htdocs/core/lib/ajax.lib.php is necessary but not sufficient.
If $conf->global->PRODUIT_USE_SEARCH_TO_SELECT, 0, combo remains even the product selected is alone. So an action is necessary to choose it by mouse or down arrow, it's slower.
So I recommend to have $conf->global->PRODUIT_USE_SEARCH_TO_SELECT, 1, for customer order filling where the probability is higher to use a barcode scanner.
For supplier order, considering that the barcode reader is less useful and that it's convenient to see the complete product information (description, price) on the combo before to confirm, I would maintain the value $conf->global->PRODUIT_USE_SEARCH_TO_SELECT, 0,
Particularly because also that the supplier price box is not currently automatically filled.
See also screen shots in my previous answer.
Thank you for your attention and patience. I don't really know if it's the good way to proceed.