fix:allow customer and supplier codes bigger than 15 chars #16480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Feb 28, 2021
| @@ -2224,6 +2225,344 @@ function init_supplier_categ() { | |||
| print $form->select_incoterms((!empty($object->fk_incoterms) ? $object->fk_incoterms : ''), (!empty($object->location_incoterms) ? $object->location_incoterms : '')); | |||
| print '</td></tr>'; | |||
| } | |||
| ======= | |||
eldy
reviewed
Feb 28, 2021
| print '<table class="nobordernopadding"><tr><td>'; | ||
| $tmpcode = $object->code_fournisseur; | ||
| if (empty($tmpcode) && !empty($modCodeFournisseur->code_auto)) $tmpcode = $modCodeFournisseur->getNextValue($object, 1); | ||
| print '<input type="text" name="supplier_code" id="supplier_code" class="maxwidthonsmartphone" value="'.dol_escape_htmltag($tmpcode).'" >'; |
There was a problem hiding this comment.
What happen if we enter a value with 300 chars ?
Field in database is limited to 24, so we should have maxlength = 24.
|
I think that only 24 chars are saved as limited in llx_societe table with code_client varchar(24) |
|
With another PR, i modified max from 15 to 24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
This is a template to help you make good pull requests. You may use Github Markdown syntax to format your issue report.
Please:
Fix #[issue_number Short description]
[Long description]
Close #[issue_number Short description]
[Long description]
New [Short description]
[Long description]