fix message creted ticket trans no entities #16629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Mar 12, 2021
| @@ -307,7 +307,7 @@ | |||
| //setEventMessages($langs->trans('YourTicketSuccessfullySaved'), null, 'mesgs'); | |||
|
|
|||
| // Make a redirect to avoid to have ticket submitted twice if we make back | |||
| setEventMessages($langs->trans('MesgInfosPublicTicketCreatedWithTrackId', '<strong>'.$object->track_id.'</strong>', '<strong>'.$object->ref.'</strong>'), null, 'warnings'); | |||
| setEventMessages($langs->transnoentities('MesgInfosPublicTicketCreatedWithTrackId', '<strong>'.$object->track_id.'</strong>', '<strong>'.$object->ref.'</strong>'), null, 'warnings'); | |||
There was a problem hiding this comment.
The ->tans should be required because setEventMessages will then output the string with ->trans only if string is a translation keyword. If a full text, it will remains.
Did you trouble was on a char inside the trackid or the ref ?
There was a problem hiding this comment.
It display ".... " Into the set event message. Maybe we should let trans but put html into translation files?
There was a problem hiding this comment.
Does this fix 5a806c1 is ok for you?
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix message created ticket trans no entities