Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW date and user signature on proposal (Issue 16062) #16980

Merged
merged 4 commits into from
Mar 30, 2021
Merged

NEW date and user signature on proposal (Issue 16062) #16980

merged 4 commits into from
Mar 30, 2021

Conversation

lvessiller-opendsi
Copy link
Contributor

NEW date and user signature on proposal (Issue 16062)

  • add "date_signature" and "fk_user_signature" fields in "propal" table and in class

@BB2A-Anthony
Copy link
Contributor

BB2A-Anthony commented Mar 27, 2021 •
edited

Is good proposal
date_signature is not éditable in formconfirm?
date_signature is dates user confirm signed in dolibarr?
If user confirm also days after signted real

@lvessiller-opendsi
Copy link
Contributor Author

@BB2A
It's a feature and I used horodate such as validation and close date (not modified in propal card).
I understand what you want to do, but I already have a lot of changes.
I think it could be a new feature if we need to edit signature date directly from propal card.

eldy
eldy reviewed Mar 29, 2021
View reviewed changes
htdocs/comm/propal/card.php
@@ -642,7 +642,7 @@
if ($object->statut == $object::STATUS_VALIDATED) {
$db->begin();

$result = $object->cloture($user, GETPOST('statut', 'int'), GETPOST('note_private', 'restricthtml'));
$result = $object->signature($user, GETPOST('statut', 'int'), GETPOST('note_private', 'restricthtml'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the user that set the status of proposal to "signed" by customer is saved into field fk_cloture (for "closed as signed").
What will be the goal of having a second field ?
Is it to track a status signed by customer or signed by the company ?
Is it to add a second level of validation of proposal by a second user different than the one who validate the proposal before sending it to the customer ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eldy
Having a second field is needed to differenciate user who sign and user who close the commercial proposal (as we defined in issue 16062).

Copy link
Member

@eldy eldy Mar 29, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
So you confirm there is no added step, just a different field used when storing the "signed status".
If yes, last step is to merge the conflict (github does not allow me to make it from github interface for this PR)

@eldy eldy added Discussion Some questions or discussions are opened and wait answers of author or other people to be processed PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) PR OK to merge PR was analyzed by PR merger and seems ok to be validated. Merge may occurs soon... and removed Discussion Some questions or discussions are opened and wait answers of author or other people to be processed labels Mar 29, 2021
@lvessiller-opendsi
Copy link
Contributor Author

@eldy
I tried to resolve conflicts.
I got a Travis error but it should not concern this feature.

@eldy eldy merged commit cdd3e38 into Dolibarr:develop Mar 30, 2021
@BB2A-Anthony
Copy link
Contributor

No translate in en_US ?

@lvessiller-opendsi lvessiller-opendsi deleted the new-propal-signature-date-and-user branch March 31, 2021 06:10
@lvessiller-opendsi
Copy link
Contributor Author

@BB2A

No translate in en_US ?

Completed in new PR 17056

@BB2A-Anthony
Copy link
Contributor

Ok sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldy eldy eldy left review comments

Assignees
No one assigned
Labels
PR OK to merge PR was analyzed by PR merger and seems ok to be validated. Merge may occurs soon... PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lvessiller-opendsi @BB2A-Anthony @eldy