Fix variants issues: decimal separator not always parsed right + fatal on variant list #18313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed a better fix. Thanks to try it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fatal on variant list + decimal sep. parsing
The fatal error occurs on
htdocs/variants/list.phpbecause classProductis redeclared (usingrequire_onceinstead ofrequirefixes it).The other error occurs when you save a variant with a non-percentage variation (box unchecked) using a decimal separator other than ".": the value is not saved properly. Applying
price2numfrom the moment the HTTP parameter value is assigned to its variable fixes the problem.