FIX: price impact of new combination is always a percentage even if the checkbox was unchecked #18397
Conversation
…he checkbox was unchecked (cf. https://www.dolibarr.fr/forum/t/bug-sur-le-variants/37455/2)
| @@ -137,9 +137,10 @@ | |||
| // for conf PRODUIT_MULTIPRICES | |||
| if ($conf->global->PRODUIT_MULTIPRICES) { | |||
| $level_price_impact = array_map('price2num', $level_price_impact); | |||
| $level_price_impact_percent = array(1 => $price_impact_percent); | |||
There was a problem hiding this comment.
Why only the key 1 is filled? Later we used the array with index [$i] where $i is the price level.
Can you check if this is ok ?
$level_price_impact_percent = array();
for ($i = 1; $i <= $conf->global->PRODUIT_MULTIPRICES_LIMIT; $i++) {
$level_price_impact_percent = array($i, $price_impact_percent);
}
There was a problem hiding this comment.
I’ll check this with @atm-john next time I see him, because I am not very familiar with multiprice.
There was a problem hiding this comment.
I (finally) discussed it with John: seems OK at first look, but we want to review it once more to be sure.
eldy
added
the
Discussion
|
Does this bug still true with v17 ? |
eldy
added
the
Bug need more information
|
@atm-florianm can we close this ? Or bug still exists in v18 ? |
|
It seems this PR was set with "Discussion" or "PR to fix" tag, but no answer nor correction was provided since a long time. So request is automatically closed. |
FIX cf. forum thread
When you create a new product combination, even if you leave the "Percentage variation" checkbox empty, the price impact is considered a percentage.
This is caused by the attribute
variation_price_percentageofProductCombinationbeing either an array or a boolean depending on whetherPRODUIT_MULTIPRICESis used: it seems to me that in the lines I changed, it was set as an array when it should have been a boolean and vice versa.My changes fix the problem as it was described, however, I am not very familiar with the multiprice feature, so I’d gladly wait for someone more experienced to take a second look.