Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translate.class.php #1888

Closed
wants to merge 2 commits into from
Closed

Conversation

defrance
Copy link
Contributor

problem with translation of select list

problem with translation of select list
@rdoursenaud
Copy link
Contributor

Well, you could at least syslog a warning. Best of both worlds ;)

@defrance
Copy link
Contributor Author

UP!

@hregis
Copy link
Contributor

hregis commented Oct 14, 2014

use
if (isset($key) && $key == '')
instead
if (! $key)

@defrance
Copy link
Contributor Author

thank's regis, changes made

@defrance
Copy link
Contributor Author

defrance commented Nov 4, 2014

UP

@defrance
Copy link
Contributor Author

Error is present on standard dolibarr need a fix urgently !

error on last dolibarr standard

@marcosgdf
Copy link
Contributor

I agree with returning an empty value. If anything entered cannot be translated, return the given string to not break the view. A different thing would be giving it something different than string

@FHenry
Copy link
Member

FHenry commented Nov 19, 2014

I agree with charles, trans '' should not return ErrorBadValueForParamNotString but ''.

@defrance
Copy link
Contributor Author

hope fix for Xmas ;-)

@defrance
Copy link
Contributor Author

defrance commented Feb 9, 2015

Hello
Sorry but i Still waiting for this correction
version 3.7 should soon go out and still have to wait six months to address this issue is not acceptable

@eldy
Copy link
Member

eldy commented Apr 2, 2015

Calling this function with a '' means there is a bug BEFORE the call. The string ErrorBadValueForParamNotString is required to report there is a bug to fix.
I seriously can't accept a PR to "hide" a bug, even if bug is inside dolibarr core code. I prefer accept the PR that will fix the bug.

@eldy eldy closed this Apr 2, 2015
@defrance defrance deleted the patch-21 branch April 21, 2016 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants