NEW support of Stripe Terminal with Takepos #19444
Conversation
With availability in Europe (France, UK, Ireland...) Only support smart readers
|
PR functionnal with virtual test reader include in stripe SDK and demo card include in code |
|
Terminal ordered with test card and shipping planned for this week |
ptibogxiv
changed the title
|
Just need more informations when error and loading |
|
@eldy @andreubisquerra now is fully fonctionnal! test with Stripe smart reader bbpos wisepos E I introduce some notifications for following the actions and errors ie pin error or card declined (can be used by other code) |
eldy
added
the
PR postponed
|
I added this to my configuration and it works swell but the payment screen "pay.php" still shows "Credit Card" as a payment type. I believe credit card still has to be active for this to work but the extra button on the GUI in TakePOS is confusing. |
|
|
||
| /* | ||
| * View | ||
| */ | ||
|
|
||
| if (!empty($conf->stripe->enabled) && (empty($conf->global->STRIPE_LIVE) || GETPOST('forcesandbox', 'alpha'))) { |
There was a problem hiding this comment.
If "CASHDESK_ID_BANKACCOUNT_STRIPETERMINAL".$terminaltouse is not set, it means we don't want to use Stripe for payment on takepos. Right ?
If right, can you add a condition here to avoid to make warning "We are in sandbox" when Stripe for Takepos has not bee enabled ?
| @@ -314,7 +521,11 @@ function ValidateSumup() { | |||
| ), | |||
| ); | |||
| $numpad = $conf->global->TAKEPOS_NUMPAD; | |||
|
|
|||
| if (!empty($conf->stripe->enabled) && !empty($conf->global->STRIPE_CARD_PRESENT)) { | |||
There was a problem hiding this comment.
Same here: If "CASHDESK_ID_BANKACCOUNT_STRIPETERMINAL".$terminaltouse is not set, we should not output the message.
| @@ -421,8 +632,18 @@ function ValidateSumup() { | |||
| $i = $i + 1; | |||
| } | |||
|
|
|||
| $keyforsumupbank = "CASHDESK_ID_BANKACCOUNT_SUMUP".$_SESSION["takeposterminal"]; | |||
| if (!empty($conf->stripe->enabled) && !empty($conf->global->STRIPE_CARD_PRESENT)) { | |||
There was a problem hiding this comment.
Same. Must be used only if stripe payment enabled for the current terminal $_SESSION["takeposterminal"]
eldy
added
PR OK to merge (but suggested fix required)
With availability in Europe (France, UK, Ireland...)
Only support smart readers ie javascript and not only iOs and Android
@eldy @andreubisquerra