Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW - Shipping address to invoice #22832

Merged
merged 16 commits into from Nov 25, 2022

Conversation

BB2A-Anthony
Copy link
Contributor

@BB2A-Anthony BB2A-Anthony commented Nov 13, 2022

NEW|New [Shipping address to invoice]

Add shipping address to invoice

If a delivery address is defined, it is displayed.
If a billing address is defined, I consider that the delivery address is the one on which the invoice was made.

image

@StephaneBRT
Copy link

very useful feature. thank you very much.

@eldy
Copy link
Member

eldy commented Nov 17, 2022

Great.
The template crabe is deprecated and will be replaced soon by template sponge. So can you add also the same change into template sponge ? Both templates are similar so change should be cut and paste (i hope).
Because this is legal need, this new feature could be merged despite the freeze.

@eldy eldy added Priority - Top Strategic PR is in list of TOP strategic priorities (main desired roadmap). This tag usage is reserved Priority - High / Blocking This is a security hole or a bug that make a feature not possible to use or very expected feature. and removed Priority - Top Strategic PR is in list of TOP strategic priorities (main desired roadmap). This tag usage is reserved labels Nov 17, 2022
@BB2A-Anthony
Copy link
Contributor Author

Great.

The template crabe is deprecated and will be replaced soon by template sponge. So can you add also the same change into template sponge ? Both templates are similar so change should be cut and paste (i hope).

Because this is legal need, this new feature could be merged despite the freeze.

In my case, I only display it if it is different from the billing address! Should there always be a delivery address even if it is the same?

Dans mon cas je ne l'affiche que si elle est différente de l'adresse de facturation! Faut il qu'il y ai toujours une adresse de livraison même si elle est la même?

@BB2A-Anthony
Copy link
Contributor Author

Great. The template crabe is deprecated and will be replaced soon by template sponge. So can you add also the same change into template sponge ? Both templates are similar so change should be cut and paste (i hope). Because this is legal need, this new feature could be merged despite the freeze.

@eldy it's done and I improved the code

@aspangaro aspangaro requested a review from eldy November 20, 2022 21:23
@@ -69,6 +69,10 @@
dolibarr_set_const($db, "INVOICE_ADD_SWISS_QR_CODE", GETPOST("INVOICE_ADD_SWISS_QR_CODE", 'int'), 'chaine', 0, '', $conf->entity);
dolibarr_del_const($db, "INVOICE_ADD_ZATCA_QR_CODE", $conf->entity);
}
if (GETPOSTISSET('DOC_SHOW_SHIPPING_ADDRESS')) {
Copy link
Member

@eldy eldy Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean INVOICE_SHOW_SHIPPING_ADDRESS instead of DOC_SHOW_SHIPPING_ADDRESS ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a change @eldy

@eldy eldy added the PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) label Nov 22, 2022
@eldy eldy merged commit 64950e9 into Dolibarr:develop Nov 25, 2022
@BB2A-Anthony BB2A-Anthony deleted the NEW---Shipping-address-to-invoice branch November 25, 2022 21:57
@hasse-basse
Copy link

As a clarification, at least in France, it is not a legal requirement to mention the delivery address on invoices when conducting B2B sales. This requirement is typically applicable when selling to consumers (B2C). Therefore, it would be beneficial to have a checkbox option on the invoice card, allowing to choose whether or not to include the delivery address for each specific invoice. Or maybe it could be controlled in the settings of what kind of client it is? Remeber that in B2B sales there can be many delivery adresses on one invoice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) Priority - High / Blocking This is a security hole or a bug that make a feature not possible to use or very expected feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants