unify categories #25269
Closed
unify categories #25269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frederic34
commented
Jul 4, 2023
•
frederic34
commented
- sql
- migration can be run several times, old tables will be deleted in v20
- use new table in category class
- sql changes
unify categories unify categories
frederic34
force-pushed
the
unify_all_categories
branch
from
cb4f632
to
f1cdfef
Compare
frederic34
force-pushed
the
unify_all_categories
branch
from
ac6af29
to
f5b3fee
Compare
frederic34
force-pushed
the
unify_all_categories
branch
from
aca014c
to
2f7f28e
Compare
|
@eldy can i have some feedback ? |
|
@eldy can you review ? |
|
@eldy ? |
|
no review for about five months so bye bye PR |
|
@eldy how come you didn't review this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.