New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX user notification for ticket assigned on creation #25866
Open
altairis-benjamin
wants to merge
15
commits into
Dolibarr:develop
Choose a base branch
from
altairis-benjamin:assignNotif
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FIX user notification for ticket assigned on creation #25866
altairis-benjamin
wants to merge
15
commits into
Dolibarr:develop
from
altairis-benjamin:assignNotif
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Sep 11, 2023
eldy
added
the
PR to fix or conflict to solve
PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
label
Sep 11, 2023
I made the changes. |
Any update on here? |
@eldy all the pre-commit tests are now ok :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR to fix or conflict to solve
PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an user is assigned to a ticket directly during the creation, there is no email notification whereas there is one when the user is assigned AFTER the creation.
I propose this little change in order to fix it and notify an user even when he's assigned during the ticket creation.