FIX it creates side effects after logout with takepos #28978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Mar 19, 2024
| @@ -73,7 +73,8 @@ | |||
| // We will recalculate amount for foreign currency at next call of invoice.php when $_SESSION["takeposcustomercurrency"] differs from invoice->multicurrency_code. | |||
| } | |||
|
|
|||
| $_SESSION["urlfrom"] = '/takepos/index.php'; | |||
| // TODO it creates side effects | |||
| //$_SESSION["urlfrom"] = '/takepos/index.php'; | |||
There was a problem hiding this comment.
This seems to introduce a problem with the logout from takepos.
After this change when we logout from Takepos, we go back on login (good), but when we login, we do not reach the takepos page again.
Instead we reach the backoffice (with sometimes an access error when users are allowed to use the takepos only).
What was wrong with old code ?
eldy
added
the
Discussion
|
I pushed a fix that replace the session with a param in url in develop and have cherry pickedninto v19 and 18. Can you test it's ok for you in your v18 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.