#29026 [Class] fix: selectForForms issue on check fields before use for modification on objectdesc #29027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re use for modification on objectdesc
Closed
eldy
reviewed
Mar 23, 2024
| @@ -8040,7 +8040,6 @@ public function selectForForms($objectdesc, $htmlname, $preSelectedValue, $showe | |||
| if ($objectfield) { // We must retreive the objectdesc from the field or extrafield | |||
| // Example: $objectfield = 'product:options_package' | |||
| $tmparray = explode(':', $objectfield); | |||
| $objectdesc = ''; | |||
There was a problem hiding this comment.
I removed this line because the variable is defined in the if and else.
But it's true that there is a case where it could be redefined if this condition is false !empty($extrafields->attributes[$objectforfieldstmp->table_element]['param'][$key]['options']))
I can put it back if I need to
There was a problem hiding this comment.
Hello @eldy
Awaiting your reply for this fix
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29026